EHDEN / CdmInspection

R Package to support quality control inspection of an OMOP-CDM instance
Apache License 2.0
11 stars 16 forks source link

add missing variables as arguments #51

Closed sdebruyn closed 3 years ago

sdebruyn commented 3 years ago

Relying on global scoped variables is a bad practice. I included the missing variables as arguments so that they're always available in the scope of the method.

Fixes #47

PRijnbeek commented 3 years ago

Agree that is of course not intentional. it needs more that just updating this file. we will fix this if you for now just follow the CodeToRun and define all variables there you should be able to run.

PRijnbeek commented 3 years ago

Solved in dev