EHDEN / CdmInspection

R Package to support quality control inspection of an OMOP-CDM instance
Apache License 2.0
11 stars 16 forks source link

Description contains a blank line #55

Closed superbspeed closed 3 years ago

superbspeed commented 3 years ago

I'm getting an error when I try to add the package into RStudio Package Manager:

$ /opt/rstudio-pm/bin/rspm logs --transaction-id=108
2021/02/24 21:31:00.784353461 Error : contains a blank line
2021/02/24 21:31:00.784669645 * checking for file '/tmp/git/DESCRIPTION' ... EXISTS but not correct format
Error running /tmp/ext/timestamper: exit status 1

Can you please remove this line from DESCRIPTION?

https://github.com/EHDEN/CdmInspection/blob/776b5dca64e144657de250127255b49ebaf8c8dc/DESCRIPTION#L39

PRijnbeek commented 3 years ago

@superbspeed

Have not seen this before from any of the other data partners that run the code, but it should be removed indeed.

By the way you can always test this yourself by forking the package, making the fix, building the package, test the fix. You could contribute that fix then by doing a pull request to the Dev branch.

I will make the fix now and update the package.