EHDEN / ETL-UK-Biobank

ETL UK-Biobank
https://ehden.github.io/ETL-UK-Biobank/
13 stars 4 forks source link

Gp covid19 to visit #247

Closed SofiaMp closed 3 years ago

SofiaMp commented 3 years ago

@MaximMoinat I ve changed the hes_to_visit_detail dates to use epistart and epiend fields. However in the tests to link to visit_occurrence (we use admidate there) a date is needed (tests returned multiple rows when I tried to lookup visit_detail only with person_id), so in the tests I ve added both epistart/ epiend and admidate/disdate. I m not merging the branch, so we can discuss on Tuesday if that makes sense. The epistart seems a better option for visit_detail, as we had in the documents but we probably need to double check with Spyros how te dates are filled to be sure.