EHWUSF / HS68_2018_Project_1

0 stars 9 forks source link

Visualization Keys and Labels: Initial commit in class #20

Open NikitaThomas opened 5 years ago

NikitaThomas commented 5 years ago

Implementing Issue #9

rohitchadaram commented 5 years ago

@NikitaThomas I have added some of comments on @haleyhowe pull request work please feel free to address them, as I think you and Haley worked together on this. Overall I think this is a great idea, well executed to avoid any hard-coding in the plots. There are small nuances like using elif when you have multiple condition checks and also the unnecessary use of pass when you can tweak your if condition to negate the condition checking. Apart from those great idea and great job guys.