search

EHWUSF / HS68_2018_Project_1

0 stars 9 forks source link

Visualization Tools: Keys and Labels #23

Open haleyhowe opened 5 years ago

haleyhowe commented 5 years ago

This is the very beginning. Still need to implement different charts and also tweak inputs for visualization features/parameters within each plot.

Implementing Issue #9

haleyhowe commented 5 years ago

Please excuse my commit message about Issue #11, this was supposed to be Issue #9. Recommitted with Issue #9 in commit message.

rohitchadaram commented 5 years ago

Hi Haley, As i see I think you have 3 files committed which might be the earlier version of the code you wanted to commit. You could remove those files by checking your git status and removing those files and committing, so that once you merge with the master you don't push those additional duplicate files.

EHWUSF commented 5 years ago

OK, well, it looks like the state as of your commit 7c2f00fe is largely identical to the state of Nikita's branch after her final commit, except that you wound up with more extra files, and your main file seems to have some extra superfluous lines in it. So please refer to my comments on her PR with regards to the state up to that point.

Your extra couple commits here are good additions/cleanup past that, and overall, it's important to have your branch/PR also, since right now each of your branches only reflects your own commit history plus the final state of the other's.

Let's talk either during or after class about the best way for the two of you to proceed with cleanup and preserve the git history.