EI-CoreBioinformatics / portcullis

Splice junction analysis and filtering from BAM files
https://ei-corebioinformatics.github.io/portcullis/
GNU General Public License v3.0
39 stars 9 forks source link

[BUG] make check fails with conda python #38

Closed lucventurini closed 5 years ago

lucventurini commented 6 years ago

I am also attaching the whole log file. Test done with conda python 3.6.7 on a Ubuntu bionic machine. test-suite.log

This is the relevant output from tests/test-suite.log:


Dynamic exception type: boost::exception_detail::clone_impl<portcullis::PortcullisPythonException>
std::exception::what: std::exception
[portcullis::PortcullisPythonError*] = Unexpected python error
Traceback (most recent call last):
  File "/software/stable/portcullis/1.1.2/src/portcullis/scripts/portcullis/portcullis/rule_filter.py", line 8, in <module>
    from pandas import DataFrame
  File "/software/stable/python/3.6.7/x86_64/lib/python3.6/site-packages/pandas/__init__.py", line 23, in <module>
    from pandas.compat.numpy import *
  File "/software/stable/python/3.6.7/x86_64/lib/python3.6/site-packages/pandas/compat/__init__.py", line 47, in <module>
    PYPY = platform.python_implementation() == 'PyPy'
  File "/software/stable/python/3.6.7/x86_64/lib/python3.6/platform.py", line 1234, in python_implementation
    return _sys_version()[0]
  File "/software/stable/python/3.6.7/x86_64/lib/python3.6/platform.py", line 1192, in _sys_version
    repr(sys_version))
ValueError: failed to parse CPython sys.version: '3.6.7 (default, Oct 22 2018, 11:32:17) \n[GCC 8.2.0]'
FAIL test_full.sh (exit status: 4)```
maplesond commented 6 years ago

Thanks Luca. I'll try and figure out what's causing that issue.

maplesond commented 5 years ago

Hi Luca, I believe I have a fix for this in the develop branch, amongst a bunch of other changes. Do you want to try the make check on your side to see if it works. Due to all the issues we were having I have stripped out boost from the codebase so you'll need to make sure this is installed and configured on your system. This will make like easier in most cases I think, but will make portcullis a bit trickier to configure on the HPC environments. I've also improved the docker container and singularity recipes, so would recommend this approach if possible.

maplesond commented 5 years ago

This is fixed in the latest release. Closing ticket.