EIDA / webdc3

WebDC3 is the webinterface for EIDA.
http://geofon.gfz-potsdam.de/software/webdc3/
GNU General Public License v3.0
11 stars 10 forks source link

First event is always stripped #9

Open pevans-gfz opened 7 years ago

pevans-gfz commented 7 years ago

This seems to be because in event.py, line 1141, all lines with a '#' are ignored:

            if first.startswith('#'):
                # Comment line, so ignore it

However, in line 2623, the code basically removes another line again:

    myallrow[0] = "#"+myallrow[0]

    my_row_for_send =''

    # rebuild the resultset
    for item in myallrow:
        if(item):
            if(item[0]=="#"):
                continue

This results in two lines being ignored instead of just one and thus the first event not being displayed in the result page. I suggest to comment out

   myallrow[0] = "#"+myallrow[0] 

However, this might break compatibility with other fdsnws implementations, which don't have a hash tag in the first line of their respective output. As far as I know, this is not a requirement, as the CSV output is not standardised.

Reported by someone @ ETH.