search

EIDOSLAB / torchstain

Stain normalization tools for histological analysis and computational pathology
MIT License
118 stars 20 forks source link

Improve code readability and speed #41

Open ajinkya-kulkarni opened 1 year ago

ajinkya-kulkarni commented 1 year ago
  1. Used np.apply_alongaxis to calculate stack instead of using a list comprehension.
  2. Used elif statements instead of multiple if statements to improve code readability.
ajinkya-kulkarni commented 1 year ago

Done

andreped commented 1 year ago

In order to merge, we need to run some unit tests. This is not possible, until you have replaced ubuntu-18.04 with ubuntu-20.04, as mentioned here (necessary as ubuntu-18.04 docker image is deprecated in GitHub Actions).

See here for where to change. Alternatively, you can pull latest from the main branch to your own fork's branches.