EIDOSLAB / torchstain

Stain normalization tools for histological analysis and computational pathology
MIT License
118 stars 20 forks source link

Macenko stain augmentation #45

Open andreped opened 1 year ago

andreped commented 1 year ago

Related to issue https://github.com/EIDOSLAB/torchstain/issues/43.

Changes

Ideas from improvement

API-wise I believe there is a lot of overlap between the normalization and augmentation techniques. It would make sense to have a Macenko ABC class, of which the MacenkoNormalizer and MacenkoAugmentor classes inherit from, and then for each we just override the necessary methods.

Screenshot 2023-05-08 at 17 00 43

andreped commented 7 months ago

@carloalbertobarbano I observed that it was not possible to change sigma_1 and sigma_2 through the common MacenkoAugmentor API. I also observed that tests were failing due to some bugs in the CI workflows. I have addressed both now.