EINDEX / logseq-copilot

Logseq Copilot is a Browser extension that allows you to access your Logseq via your browser.
https://logseq-copilot.eindex.me
GNU General Public License v3.0
235 stars 21 forks source link

group block results from same page into single list item #66

Open AnweshGangula opened 2 months ago

AnweshGangula commented 2 months ago

Hi @EINDEX,

I have made some changes to group all the block results from same page into one single div in the search page. Please below screenshot for reference.

Although I think the message passing between background process and content script is not updated. I'm not sure how exactly to change that.

Please have a look and merge it if it looks good

image

EINDEX commented 2 months ago

Hi @AnweshGangula

I love this change, will making some time to review the code.

I just have one question about the sorting logic for grouped result.

Cause currently we are using same ordering as the logseq searching result.

AnweshGangula commented 2 months ago
EINDEX commented 2 months ago

Hi @AnweshGangula

I found some cases, where the style of grouped items is not as perfect as the searching page.

  1. In the popup, I think the total width in the popup is too narrow.

    Screenshot 2024-04-10 at 22 06 30

    I have some suggestions to enhance this:

    • Remove the text to block and change it to a hover prompt. After all, users do not need to see the text to block every time.
    • Increase the width of the popup so that it reaches 400px.
    • It seems that there is a bit too much left padding for each small item in the popup.
  2. The task item's style is strange in the popup and search page.

    • in popup Screenshot 2024-04-10 at 22 17 23
    • in the search page Screenshot 2024-04-10 at 22 17 30

      Maybe you are not using task items in logseq, cloud you also consider task items in grouped results.

Would you like to improve this? I realize that your frontend and UX skills are better than mine.

EINDEX commented 2 months ago
  • But I'm wondering if its better to sort the group's themselves - displaying the group with max blocks at the top, so most relevant page is displayed at the top

I agree with your point, I do not care about the sorting, but I really want the most relevant result shows on the top.