EIRTeam / Project-Heartbeat

Project Heartbeat source code release
69 stars 9 forks source link

Difficulties with slashes break the website's song browser #123

Open EIRTeam-Cirno opened 1 month ago

EIRTeam-Cirno commented 1 month ago

Steven Steven BOT

This page of the song browser https://ph.eirteam.moe/leaderboards/songs?page=8 has the song "灰色の海" by firedragon68, which leads to the url https://ph.eirteam.moe/leaderboard/steam/3165797018/extreme%20(mirai%20x%20ia/vt), which is invalid as the slash needs to be escaped.

EIRTeam-Cirno commented 1 month ago

Steven Steven BOT

If you happen to modify the difficulty url to an invalid difficulty (ex: https://ph.eirteam.moe/leaderboard/steam/3165797018/extreme?page=1), you can't click on the tab of the difficulty at the top, either, as the request fails for the same reason (unescaped slash).

EIRTeam-Cirno commented 1 month ago

Ami Ami BOT

I'll take this opportunity to piggyback https://ph.eirteam.moe/leaderboard/steam/2323194001/hard

EIRTeam-Cirno commented 5 days ago

EIREXE EIREXE BOT

Fixed, I hope

EIRTeam-Cirno commented 5 days ago

Steven Steven BOT

Yeah, the slash escaping is fixed. The other chart has a different unrelated issue with it, though.

EIRTeam-Cirno commented 5 days ago

EIREXE EIREXE BOT

What's the problem?

EIRTeam-Cirno commented 5 days ago

Steven Steven BOT

The difficulties don't match with the ones in-game. There's strange blank "outdated hard" and "outdated extreme" leaderboards. In-game has a hard and an extreme chart.