Rename framerate attribute to sample_frequency

EIT-ALIVE / eit_dash

GUI for EIT data processing

Apache License 2.0

3 stars 0 forks source link

Open psomhorst opened 1 month ago

psomhorst commented 1 month ago

In https://github.com/EIT-ALIVE/eitprocessing/pull/290 we changed the EITData.framerate attribute to EITData.sample_frequency. This will go in effect probably in v.1.3.0.

For now, EITData.framerate will produce a DeprecationWarning.

Note that this issue should only be fixed after the dash will support eitprocessing>=v.1.3.0.

@wbaccinelli Is the dash fixed to a version of eitprocessing?

wbaccinelli commented 1 month ago

@psomhorst Yes, the eitprocessing version is fixed here. When upgrading the version to the new one, this issue has to be addressed.