search

EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 0 forks source link

Uniformize containers #208

Open DaniBodor opened 3 months ago

DaniBodor commented 3 months ago

We now have 4 main data containers (EITData, IntervalData, ContinuousData, SparseData) that have some commonalities. It would be nice to make these a bit more uniform, e.g. in terms of order of common arguments, magic functions (e.g. repr) in common, etc. Perhaps, EITData.vendor can be replaced by EITData.category, to also make this more in line with each other.

As I am typing this issue, it is actually starting to sound like it would make sense to create a parent class (DataContainer?) from which each of out main containers can inherit from, and only the specifics need to change.

DaniBodor commented 3 months ago

Also create checks, e.g. regarding time points being consecutive, either all instances have values or none, etc.