search

EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 1 forks source link

222 pixel inflation #241

Closed JulietteFrancovich closed 1 month ago

JulietteFrancovich commented 2 months ago

@psomhorst this branch now contains the feature pixel inflations and the parameter TIV since they are interdependent. I have written tests for pixel inflations. Could you review the code and give your suggestions for pixel inflations and the tests? Once we are happy with that I will write the tests for parameter TIV and request review again for the entire pull request. Thanks!

JulietteFrancovich commented 2 months ago

@psomhorst Thank you for your review. I have addressed your comments and tried to incorporate your suggestions (see comments). Please let me know if you have further comments/ concerns. I will start working on tests for parameter TIV so we can review that next.

JulietteFrancovich commented 2 months ago

@psomhorst I have now written tests for parameter TIV. Could you review the TIV code and tests? Once those have been reviewed and the comments (also on pixel inflation) have been resolved to your liking, I think this branch is ready for merging.

JulietteFrancovich commented 1 month ago

@psomhorst I have addressed your comments and changed the TIV to be stored as SparseData. I have adjusted the pixel breath accordingly (since this uses TIV) and have added new tests to check the storage of TIV. Let me know if you have any further comments :)

JulietteFrancovich commented 1 month ago

@psomhorst Thank you! I have merged and deleted the branch.