EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 1 forks source link

Release workflow fails when merging #266

Closed psomhorst closed 4 months ago

psomhorst commented 4 months ago

This one probably takes too much digging for me to understand.

@DaniBodor do you know what could be the problem here?

https://github.com/EIT-ALIVE/eitprocessing/actions/runs/9870359031

psomhorst commented 4 months ago

I managed to fix this. There were some issues:

I think this currently works as intended. It took me a few tries to get it right, sorry for the multiple updates to release_github.yml: 7c46648c2b9a582f49cab2a2fabf89c1497e88bb, 9ff53b0439a485eebe26e13abdffb04601d42a2f, d4eb9ef9d15a7ae67ccddbdedc2154beaf9a3185,

DaniBodor commented 4 months ago

Are these changed grouped together in a PR somewhere? And does it now work @psomhorst ?

psomhorst commented 4 months ago

@DaniBodor No, I made the changes on main directly, so there is nothing to pull. The changes had to be on main for the action to work anyway, so a PR would not have helped.

Next time, I'll fork the repo, try fixing it in the fork, and then make a PR instead.

It does now work!