search

EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 1 forks source link

refactor: derive funcargs dbodor #271

Closed DaniBodor closed 4 months ago

DaniBodor commented 4 months ago

The function used by derive does not always require additional arguments, so it would be nice to make the func_args argument optional. See e.g. here

DaniBodor commented 4 months ago

I have one remarks. I don't think this should be called a hotfix. Hotfixes are for issues breaking functionality.

You're right. There was no issue for it yet, so I named the branch hotfix in lieu of a issue number, and then didnt change it for the PR. I did point it at develop on purpose. I now called it a refactor, which I'm not sure is technically fully correct either, as it changes functionality slightly. But I think this is close enough.