search

EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 1 forks source link

Missing dependency #299

Closed psomhorst closed 2 months ago

psomhorst commented 2 months ago

typing_extensions is used, but is not part of the dependency list. `It should only be loaded for type checking, but it is always loaded in eitdata.py. It is not only used for type checking, so it should be available for the normal install.

psomhorst commented 2 months ago

@DaniBodor This bug could fly under the radar due to GitHub automations only testing the [dev] install, which includes the typing_extensions (via sphinx-autoapi and astroid). Do you have time to see whether you can also include the normal (or all, including normal, [notebooks] and [publishing]) builds?

DaniBodor commented 2 months ago

I see that this got closed before I had time to look into it. Do I still need to look into it?

I thought that typing_extensions is a built-in package (similar to os), but am not positive.

psomhorst commented 2 months ago

The issue itself is closed. The reason I tagged you is that it should have been caught by automated tests long ago, but wasn't because the tests only cover the [dev,publishing] install.

In my clean install with Python 12, typing_extensions is not installed by default.

From: Dani Bodor @.> Sent: Monday, September 30, 2024 1:55:34 PM To: EIT-ALIVE/eitprocessing @.> Cc: Peter Somhorst @.>; State change @.> Subject: Re: [EIT-ALIVE/eitprocessing] Missing dependency (Issue #299)

Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is. Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

I see that this got closed before I had time to look into it. Do I still need to look into it?

I thought that typing_extensions is a built-in package (similar to os), but am not positive.

— Reply to this email directly, view it on GitHubhttps://github.com/EIT-ALIVE/eitprocessing/issues/299#issuecomment-2382980260, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6QKKNWDX53JXRK7XTSJ6TTZZE33NAVCNFSM6AAAAABO6ZMIUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSHE4DAMRWGA. You are receiving this because you modified the open/close state.Message ID: @.***>