EIT-ALIVE / eitprocessing

Software for electrical impedance tomography data loading, visualization and processing
https://eit-alive.github.io/eitprocessing/
Apache License 2.0
5 stars 1 forks source link

Update distribution pipeline #314

Closed psomhorst closed 3 weeks ago

psomhorst commented 1 month ago

This PR started out small, but I added some improvements to several parts of the distribution pipeline.

DaniBodor commented 3 weeks ago

This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303

psomhorst commented 3 weeks ago

This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303

I wasn't aware of #303. Maybe it's best to do that in this PR, instead of changing it twice. I think we can already remove the container requirement by extracting the data files from the container (https://github.com/marketplace/actions/docker-extract). This can then later be replaced, e.g. by downloading from Zenodo (although downloading from Zenodo seems to be quite slow).

I'll look into this tomorrow.

psomhorst commented 3 weeks ago

Since yesterday, I have changed a number of things:

The actions that run when a PR is updated (Test and build, Linting) work.

The actions that run with a GitHub release can't be tested without creating a release. Since the tests have to succeed before the release is created, I dare to test them by making a release. If something is not right, the release will just fail. @wbaccinelli @DaniBodor Do you agree?

psomhorst commented 3 weeks ago

This PR closes #303.

psomhorst commented 3 weeks ago

I now also updated the Coveralls action to de-containerize it.

DaniBodor commented 3 weeks ago

I haven't looked closely at any of this, just added the comments I had already spotted before today's meeting. Will let @wbaccinelli review it from there.