Closed psomhorst closed 3 weeks ago
This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303
This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303
I wasn't aware of #303. Maybe it's best to do that in this PR, instead of changing it twice. I think we can already remove the container requirement by extracting the data files from the container (https://github.com/marketplace/actions/docker-extract). This can then later be replaced, e.g. by downloading from Zenodo (although downloading from Zenodo seems to be quite slow).
I'll look into this tomorrow.
Since yesterday, I have changed a number of things:
The actions that run when a PR is updated (Test and build, Linting) work.
The actions that run with a GitHub release can't be tested without creating a release. Since the tests have to succeed before the release is created, I dare to test them by making a release. If something is not right, the release will just fail. @wbaccinelli @DaniBodor Do you agree?
This PR closes #303.
I now also updated the Coveralls action to de-containerize it.
I haven't looked closely at any of this, just added the comments I had already spotted before today's meeting. Will let @wbaccinelli review it from there.
This PR started out small, but I added some improvements to several parts of the distribution pipeline.
eitprocessing
keeps working on newer versions of Python, I added the test and build action for Python 3.11-3.13.python:3.x-bookworm
instead. This makes it easier to adapt to new Python versions and replace the data image in the future, if necessary.~ See comment below for new description.main
anddevelop
.