Mark GitHub release branches as merged instead of closed

[DaniBodor]

the github release action currently marks PRs as "closed" as opposed to "merged", which is confusing because that makes it look like changes were not accepted.

[psomhorst]

I just ran into this as well. I think this is a result of how the github_release action works. Currently, it manually merges, and then later closes the PR.

Could we rewrite this to:

• If releasing form a PR:
  • Make the base of the PR main and merge the PR (gh pr edit <nr> --base main; gh pr merge <nr> --admin)
• If releasing from develop:
  • Merge develop into main using https://github.com/marketplace/actions/merge-branch.
• Use the bump-my-version action to bump the version (https://github.com/callowayproject/bump-my-version?tab=readme-ov-file#github-actions)
• Create a release on github (gh release create ...)

Tidy could then probably be simplified to merging main into develop using https://github.com/marketplace/actions/merge-branch.

[DaniBodor]

I already have a PR open for this. The reason is that I explicitly added a step to close the PR, which was unnecessary. I changed it in that PR and I think that solves the issue. The action you found might simplify the entire process (looking at it for a few seconds, it seems like either way can be done with that action). At this point, I will leave the PR as is, but if you prefer doing it with this action, then feel free to redo my PR or add on to it.

[psomhorst]

I hadn't noticed you were already working on this, so I had a crack at it. See #338. Note: this is untested.

Please feel free to ignore.