style: formatting non-python files

DaniBodor commented 2 weeks ago

EDIT: I repurposed this PR to do only the tidying up stuff, and the not-closing PRs on release part is now handled by #338

~~5d075b5: removed one step from the github release workflow that marks PRs as "closed". They should be automatically marked as "merged" in the preceeding job, when the PR is actually merged.~~
673ccc0 and e4e316e: I auto-formatted some non-python files, mainly removing trailing whitespaces in a bunch of places.
319c860: update cffconvert action. This action already existed when the CFF was faulty and should have picked those issues up but apparently didnt. I now changed it to reflect the example on the website. Walter had added a separate (different) validation step to the github release action, but I figured it doesn't hurt to have one additional one, which runs whenever a change is made to the CFF file.

DaniBodor commented 2 weeks ago

~~actually, could you hold off on reviewing this for the moment. There's one more thing I'd like to change.~~

This PR is now ready for review @psomhorst

DaniBodor commented 2 weeks ago

@DaniBodor Have you tested this? You say the PR will automatically be closed when the PR is merged, but there is no 'merge PR' action, only a 'merge branches' action. I cannot find any documentation on this automatically closing the PR.

That's a good point. I suggest moving forward with either this branch (where the old close line could be changed to a mark as merged line) or with #338, but not both. Either way, we should probably create a fork and test that it works as intended.

Let me know which solution you prefer.

DaniBodor commented 2 weeks ago

@psomhorst , I've removed the changes to the github release workflow from this PR, so now it is just some minor style changes.

EIT-ALIVE / eitprocessing

style: formatting non-python files #336