search

EJWellman / QuarmTool

Project Quarm-EQ - Log based Spell timer, dps, map, and mob info
MIT License
11 stars 1 forks source link

Fix random roll timers to allow for multiple roll ranges #19

Closed XDharkonX closed 4 months ago

XDharkonX commented 4 months ago

Currently the random roll trigger only sets a trigger for the end of the random generation. If people were rolling from 0- 100 and another person rolled from 99-100 instead, the timer shows the result in the same pane, does not account for incorrect random rolls. It only filters rolls for the end number of the roll.

EJWellman commented 4 months ago

Oooh, interesting! I'll take a look at that.

EJWellman commented 4 months ago

Sorry for the delay, but I'm actually not able to reproduce this.

image image

Can you send me a screenshot of it?

Celedh commented 4 months ago

I wasn't able to reproduce this either, and even randoms without the minimum value correctly display in the same random group as those that specify a 0 minimum (i.e. random 555 is grouped with random 0 555, while random 545 555 is in a different group showing the 545 min)

XDharkonX commented 4 months ago

tes1 test1t

Ill update to current version and see if its been fixed somehow there. Nevermind, I found it. It only occurs in the combines timers window, it is correctly displayed in the timers window.

XDharkonX commented 4 months ago

test13

EJWellman commented 4 months ago

Oooh, interesting! Looking at it now.

EJWellman commented 4 months ago

It'll be fixed in the next release. I'd forgotten that I'd made a change to it a while back, and didn't propagate the change over. Whoops!