search

ELIFE-ASU / Neet

Simulating and analyzing dynamical network models
https://neet.readthedocs.io/en/stable
Other
4 stars 10 forks source link

Landscape data #163

Closed hbsmith closed 5 years ago

hbsmith commented 5 years ago

Landscape is now a LandscapeMixin. This addresses #147.

Landscape also stores its data in another class, LandscapeData for easy access.

Tests have been updated, but documentation still needs to be updated. Will update when everything looks good enough to merge.

codecov-io commented 5 years ago

Codecov Report

Merging #163 into master will decrease coverage by 0.56%. The diff coverage is 82.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   87.91%   87.35%   -0.57%     
==========================================
  Files          16       16              
  Lines        1440     1471      +31     
==========================================
+ Hits         1266     1285      +19     
- Misses        174      186      +12
Impacted Files Coverage Δ
neet/network.py 64.28% <100%> (+0.57%) :arrow_up:
neet/boolean/sensitivity.py 96.49% <100%> (-0.04%) :arrow_down:
neet/information.py 100% <100%> (ø) :arrow_up:
neet/synchronous.py 90.82% <81.33%> (-5.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7c7fd1...447e064. Read the comment docs.

dglmoore commented 5 years ago

I think it looks pretty good. I'll add a few methods and a few tests today. Thanks for taking care of this @hbsmith!

dglmoore commented 5 years ago

@hbsmith By the way, if you change the phrasing "addresses " to "closes ", then the issue will automatically close when the pull request is merged.

hbsmith commented 5 years ago

this is great to know, thank you

On Thu, May 9, 2019 at 1:22 AM Douglas G. Moore notifications@github.com wrote:

@hbsmith https://github.com/hbsmith By the way, if you change the phrasing "addresses " to "closes ", then the issue will automatically close when the pull request is merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ELIFE-ASU/Neet/pull/163#issuecomment-490554550, or mute the thread https://github.com/notifications/unsubscribe-auth/ACHE25AMGH7OOC5Q5DI4SODPUL45VANCNFSM4HLQKXAA .