ELITR / SLTev

SLTev is a tool for comprehensive evaluation of (simultaneous) spoken language translation.
8 stars 3 forks source link

setup.py and requirements.txt duplicate the package dependencies #24

Closed bhaddow closed 3 years ago

bhaddow commented 3 years ago

Both setup.py and requirements.txt have the list of package dependencies. They can easily get out of sync (filelock was missing from setup.py). I am unsure what the pythonic solution to this is.

bhaddow commented 3 years ago

They dependencies are also listed in the README, which is unnecessary. And the README says python 3.5, whereas setup says python 3.6.

mzilinec commented 3 years ago

Hello, I don't think there's any "preferred" solution, but I would do it simply like:

with open('requirements.txt') as f:
    install_requires = f.read().splitlines()
#...
setup(
    install_requires = install_requires
)