ELITR / SLTev

SLTev is a tool for comprehensive evaluation of (simultaneous) spoken language translation.
8 stars 3 forks source link

SLTev as regular python file #34

Closed mzilinec closed 3 years ago

mzilinec commented 3 years ago

Hi, I just noticed that the main SLTev file doesn't have the .py suffix. This can cause problems when importing it as a Python module. I don't think this is the right way to install executables. The best way is using "entry points", see here. Example:

# In setup.py
entry_points={
    'console_scripts': [
        'SLTev = sltev.sltev:main',
    ],
},

Also from Python standards:

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

mohammad2928 commented 3 years ago

Thanks Matus. improved.