search

ELITR / SLTev

SLTev is a tool for comprehensive evaluation of (simultaneous) spoken language translation.
8 stars 3 forks source link

typo in function name #48

Closed Gldkslfmsd closed 3 years ago

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/c8ee0a8d9f9c1757afd88d0e52069ce2b40c8b3e/SLTev/quality_modules.py#L10

-> document ?

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/c8ee0a8d9f9c1757afd88d0e52069ce2b40c8b3e/SLTev/utilities.py#L233

-> submission

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/c8ee0a8d9f9c1757afd88d0e52069ce2b40c8b3e/SLTev/utilities.py#L153 -> Indeces ?

https://github.com/ELITR/SLTev/blob/c8ee0a8d9f9c1757afd88d0e52069ce2b40c8b3e/SLTev/utilities.py#L158

-> sub-file ?

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/1ccd4fc8dc58474a6d53990edc43066007183caf/SLTev/delay_modules.py#L245

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/1ccd4fc8dc58474a6d53990edc43066007183caf/SLTev/ASRev.py#L118

-> mwersegmenter

Gldkslfmsd commented 3 years ago

https://github.com/ELITR/SLTev/blob/1ccd4fc8dc58474a6d53990edc43066007183caf/SLTev/ASRev.py#L118

-> mwersegmenter , and several times in this function.

This function seems copy-pasted from the previous. It's not good to use code repetitions.

mohammad2928 commented 3 years ago

Improved. Many Thanks.

obo commented 3 years ago

Seems OK. Feel free to reopen or create new issues if more typos are found.