Split events server

[Gldkslfmsd]

TODO:

• [x] events are working fast, launched as online-text-flow events
• [x] python3 elitr/onlinetextflow/events.py -h -- it has a warning
• [x] import elitr.onlinetextflow.events from other script -- probably needs fix
• [x] client doesn't crash
• [x] to_brief, from_brief
• [x] import textflow_protocol
• [x] online-text-flow-serer server does something on start, but the rest?

@srdecny , please check

• [ ] the server
• [ ] installation of the server from empty p3.7 environment
• [ ] no missing dependencies
• [ ] no unused dependencies
• [ ] installation in various dockers and other places -- the correct way, not ...install
• [ ] client really works
• [ ] etc.

Let's pull it when it's 100% reviewed.

[Gldkslfmsd]

So, Ota, how do you find it now? @otakar-smrz

• it works as it used to, online-text-flow server or online-text-flow-server
• your commit from main is merged
• there are 2 directories for sources of the server and the rest
• it runs fast, due to no importing of everything for online-text-flow [something]
• found out that server can't run with 3.6 for now, need to change asyncio.run . TODO for someone else.
• only one installation point
• README should be reverted

[Gldkslfmsd]

so, I found that even the two old suggested ways of installation were wrong, and found a better one. See make install .

Compare the duration of events.

1) the optimal one:

make make check

2) make develop make check

3) make editable make check

[otakar-smrz]

I suggest we move elitr/otf_server into elitr/onlinetextflow/server, and that will solve the issue. I will then handle the move of server.py into __init.py__, and that should be all we need, and enough :) I mean, the Makefile is interesting, feel free to keep it. I suggest we revert README.md to the version before the split, and I will only update the server subfolder information and the move from server.py to server/__init__.py. Please add all your recommendations about the right install procedure. Thanks!

[Gldkslfmsd]

server.py doesn't have to be moved to server/__init__.py . It's better as server.py and server/__init__.py can be empty.

[otakar-smrz]

This server.py vs server/__init__.py made me search on how imports are done. Both files cannot coexist. Also with Python 3.3, implicit namespace packages should require no __init__.py in the namespace directory. I will change that in the master later on, and I prefer server/__init__.py and all related files in the server/ folder, too.

https://www.python.org/dev/peps/pep-0420/#specification

[otakar-smrz]

@Gldkslfmsd

Thanks for the suggestions in this branch. I have looked into some a bit more, like the dynamic module imports with elitr.onlinetextflow.__init__. Now online-text-flow COMMAND works efficiently, importing only the needed submodules.

Can you please proceed with reviewing the diff, and go ahead with merging the Makefile and any remaining changes in README.md? Thank you.

[Gldkslfmsd]

Hi, I merged master into this branch (because it had several good new changes), and changed the README. I propose merge into master now. The last question is, how. Merge, or merge squash, or rebase and merge?

[otakar-smrz]

Hi, if the diffs are in new files or additions in README.md, I do not mind. I actually do not know git to that detail, anything linear seems fine :) I have just checked Makefile, it still assumes the separate otf_server folder ... Thanks :)