ELIXIR-Belgium / elixir-toolkit-theme

Flexible Jekyll theme using bootstrap 5 as CSS framework.
https://elixir-belgium.github.io/elixir-toolkit-theme/
MIT License
20 stars 16 forks source link

Change background for affiliations and contributors? #173

Closed supernord closed 1 year ago

supernord commented 1 year ago

The affiliation and contributor boxes that the ETT renders appear to have a set background colour (see example below). This will sometimes clash with logos that have a different background.

Maybe the boxes could have a transparent background?

image
bedroesb commented 1 year ago

Hello @supernord, thanks for the feedback. Out of experience, if a logo has a background, it is white because of a png they got somewhere (and if it is a different background than white, it most of the time is because they screen-shotted it instead of saving). So if I make it transparent, it will be gray like the whole box, and than those white background logo's will pop out compared to the other ones. The idea is also that they look clickable :) Hope this does answer some things!

supernord commented 1 year ago

Thanks @bedroesb - that makes sense - what about the affiliations box itself? maybe that could be transparent instead of gray?

bedroesb commented 1 year ago

lets have a look, originally I wanted to have the same look as contributors:

Screenshot from 2023-06-13 09-57-24 Screenshot from 2023-06-13 09-57-20

supernord commented 1 year ago

Thanks @bedroesb - I like the transparent background 😄 - what do you think? If they ideally need to match, maybe the contributors box could also be transparent?

bedroesb commented 1 year ago

I think taking the background color away for affiliations might actually help in the infectious disease toolkit. There the affiliations are about the workflow described, and not about the contributors of the page. Making it look different from the contributors will already help with that!