search

ELIXIR-NO / FEGA-Norway

FEGA-Norway Mono repo
Apache License 2.0
0 stars 0 forks source link

Lega commander 100 files limit bug #188

Open joshbaskaran opened 2 months ago

joshbaskaran commented 2 months ago

LC only lists the 100 first files and ignores the rest. Also affects the "check if file already exists" test.

Could be a limitation that we only get 100 entries returned "by default?" from TSD File API? NB: The current implementation allows the user to upload the same file twice, overwriting the first uploaded file, if user has more than 100 files in inbox.

joshbaskaran commented 2 months ago

From the initial look, I don't think the problem is entirely on the lega-commander. We need to check the response from TSD side to see the shape of the response and what exactly we are getting. Probably gives a better understanding as to what we receive and make adjustments accordingly.

pavelvazquez commented 1 month ago

I reviewed the documentation (link) and confirmed that setting "per_page": "1000" adjusts the default file listing limit from 100 to 1000. I've updated this in the code. It needs testing to verify the change.

kjellp commented 1 month ago

Excellent! I guess we also need a graceful way of handling a lot of files, sorting them etc, may already be a different card for this.

So nice we've found the reason/measure to get all the information, then we need to use that tool to implement both the "does a file exist already in the inbox" check and the task of "nicely and userfriendly display all the files to a user" :)

pavelvazquez commented 2 weeks ago

I have submitted this an issue https://github.com/unioslo/tsd-file-api/issues/253