ELTE-DH / NoSketch-Engine-Docker

A NoSketch Engine Docker image which is easy to use
GNU Lesser General Public License v3.0
16 stars 9 forks source link

Our Fork #18

Open Querela opened 3 weeks ago

Querela commented 3 weeks ago

Hi,

thank you for your public repo. We used this in our fork with some additional changes. And after some cleanup and reorganizing we now finally have made it public. Yay.

What could be of interest to you is how we decided to add changes to the noske source files. It was mostly necessary since we had too many modifications to apply them with sed etc. in the Dockerfile. Our approach is to store our changes in a kind of overlay folder, so on build we extract the original source files and then overwrite specific files with our changes. Upgrading versions requires us to check for changes but this is mostly true when using sed, too, even if a bit more effort.

We also added some primitive method to scope corpora by user (when using auth) but this is something we are still working on to make more robust...

Lots of modifications are also just for our setup, so are probably not too relevant to you.

dlazesz commented 1 week ago

Thank you for your feedback!

We certainly will check your repo and evaluate what changes we will apply.