search

ELTE-Soft / txtUML

Textual, eXecutable, Translatable UML
http://txtuml.inf.elte.hu
Eclipse Public License 1.0
26 stars 9 forks source link

Improve visualization wizards #582

Open djnemeth opened 6 years ago

djnemeth commented 6 years ago

If a diagram description starts with a Spacing statement, both Papyrus and JS visualization silently fails because their wizards try to guess – using duplicated code [1, 2] – the underlying model of the layout description from its first annotation, but in case of Spacing this is not possible, as it doesn't contain the necessary model information to do so.

The lesson is that wizards should

  1. not fail silently,
  2. be able to detect the underlying model even in cases like above, and
  3. be refactored to eliminate code duplication.
djnemeth commented 6 years ago

I recommend to address this in branch visualization-refactoring.

szokolai-mate commented 6 years ago

Code duplication adressed in 10a14cd0f5632cdea5e318d426ad0d461ef40322

szokolai-mate commented 6 years ago

I think this is done, requesting review and closure.