search

ELVIS-Project / vis-framework

Thoroughly modern symbolic musical data analysis suite.
http://elvisproject.ca/
31 stars 6 forks source link

Cannot set something to None in the workflow manager settings #257

Closed juliusrain closed 10 years ago

juliusrain commented 10 years ago

The third parameter of 'settings' is defaulted to None, which means print the setting. For a setting like 'offset', once you set it, you can't set it back to None. Since None actually means 'no offset', this might be a problem.

crantila commented 10 years ago

Catch-22 of using None as the default parameter value, as recommended.

crantila commented 10 years ago

Maybe for this setting it should be "set to 0.0 or 0?" Or do you think this is something we should solve "once and for all" for every possible setting? I'm not sure how, because even a string that says u'None' could eventually cause problems.

juliusrain commented 10 years ago

I'd say set to 0. Seems like the right thing to do.