search

ELVIS-Project / vis-framework

Thoroughly modern symbolic musical data analysis suite.
http://elvisproject.ca/
31 stars 6 forks source link

Dependency cleanup #355

Closed maxalbert closed 9 years ago

maxalbert commented 9 years ago

Allow pandas 0.16.x and remove special dependency_link for music21 (since versions >= 2.0.3 were released a while ago).

mrbannon commented 9 years ago

Thanks. I've actually got the same fix in my branch, but I'll make sure you're credited. :) On Aug 16, 2015 1:04 PM, "maxalbert" notifications@github.com wrote:

Allow pandas 0.16.x and remove special dependency_link for music21 (since

versions >= 2.0.3 were released a while ago).

You can view, comment on, or merge this pull request online at:

https://github.com/ELVIS-Project/vis-framework/pull/355 Commit Summary

  • Allow pandas version 0.16.x in requirements.
  • Remove special dependency link for music21 because versions >=2.0.3 were released a while ago.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/ELVIS-Project/vis-framework/pull/355.

maxalbert commented 9 years ago

Ah, great! Don't worry about the credit if it's any hassle at all. So long as the change somehow makes it into the repo I'm happy. :)

By the way, for future reference, which branch is it usually best to submit PRs against? I checked develop, and it still has the requirement pandas<0.16, but I didn't check any other branches.

mrbannon commented 9 years ago

Develop. Pandas is one dep. I forgot to check, so thanks for that. On Aug 16, 2015 13:35, "maxalbert" notifications@github.com wrote:

Ah, great! Don't worry about the credit if it's any hassle at all. So long as the change somehow makes it into the repo I'm happy. :)

By the way, for future reference, which branch is it usually best to submit PRs against? I checked develop, and it still has the requirement pandas<0.16, but I didn't check any other branches.

— Reply to this email directly or view it on GitHub https://github.com/ELVIS-Project/vis-framework/pull/355#issuecomment-131588801 .

mrbannon commented 9 years ago

Taken care of in other pulls/commits.