Simple way of loading all files in a given directory.

ELVIS-Project / vis-framework

Thoroughly modern symbolic musical data analysis suite.

http://elvisproject.ca/

31 stars 6 forks source link

Simple way of loading all files in a given directory. #369

Closed alexandermorgan closed 8 years ago

alexandermorgan commented 8 years ago

This used to exist with the workflow manager I believe but if we still have it I haven't been able to find it anywhere. This should be a part of the core framework. Perhaps it should be a method in indexed_piece.py.

musicus commented 8 years ago

yes...that's why i started on something else ...

alexandermorgan commented 8 years ago

@musicus , why was this issue reassigned to me when you've already been working on it?

musicus commented 8 years ago

Closing the issue. The feature, along with reading files directly from the ELVIS database, will be part of the VIS-Aardvark extension.

alexandermorgan commented 8 years ago

I still don't see why this would be in an extension since importing files is core functionality. Also this issue should stay open until the fix is available in the master branch.

musicus commented 8 years ago

Perhaps. In that case build it. I'll continue to use my own.

minamouse commented 8 years ago

Alright, I added this functionality to aggregated pieces. It now takes:

a list of indexed pieces (as before)
a list of files (new)
a path to a folder from which it can also extract the meta data if present (new)
a list of links (new)

Also for all the options above you can now also add metadata as an input option as well.

Now, I'm working on adding something that can parse through larger json files and extract all the music and metadata from that (but that has more to do with issue #138 than this one). Aggregated pieces should work the same as it did before, but with some added flexibility.