search

EMATech / MidiExplorer

Yet another MIDI monitor, analyzer, debugger and manipulation tool.
GNU General Public License v3.0
46 stars 1 forks source link

Fixes for running on modern systems #5

Closed denilsonsa closed 1 year ago

denilsonsa commented 1 year ago

Old versions of python-rtmidi fail to compile on modern systems:

  src/_rtmidi.cpp:243:12: fatal error: longintrepr.h: No such file or directory
    243 |   #include "longintrepr.h"
        |            ^~~~~~~~~~~~~~~
  compilation terminated.
  error: command '/usr/bin/gcc' failed with exit code 1
  [end of output]

Newer version seems to work fine.

Also, newer mido versions removed the __version__ attribute, replacing with version_info, which was introduced in version 1.2.0 (2017-03-07), from six years ago.

My system is Manjaro Linux with Python 3.11.3.

rdoursenaud commented 1 year ago

Thanks for the pull request!

I did know about these issues - I'm now mido's co-maintainer after all - fixed them locally but didn't commit yet :/

Hope you're enjoying Midi Explorer nonetheless.

denilsonsa commented 1 year ago

Hope you're enjoying Midi Explorer nonetheless.

As someone who has just started hacking together some Web MIDI interface (nothing public yet), I'm quite pleased to see how complete MidiExplorer is.

And also surprised that there is another completely unrelated project also named midiexplorer. And also annoyed that the version from PyPi doesn't work (i.e. pip install midiexplorer doesn't work).

rdoursenaud commented 1 year ago

As someone who has just started hacking together some Web MIDI interface (nothing public yet), I'm quite pleased to see how complete MidiExplorer is.

That's one of the use cases I designed it for! Perfect 💯 I'd appreciate any feedback once your project moves along.

And also surprised that there is another completely unrelated project also named midiexplorer. And also annoyed that the version from PyPi doesn't work (i.e. pip install midiexplorer doesn't work).

Sorry for these, I'm entirely responsible.

I saw way too late there was a name collision and was kinda committed to the name, already having invested a bit of time putting a logo together.

About the pip release: I consider the project to still be in its early stages and protype-ish. I did release an early alpha to gather interest but can't bring myself to publish another one before some major features in progress are stable enough. Especially the Standard MIDI File analyzer and the Universal System Exclusive decoder. Early work on these is hidden behind the DEBUG flag in _config_.py if you're adventurous enough 🙈.

I will try and do some of the ground work in mido itself first since I believe it could be useful for a larger audience. I'd really appreciate feedback about my plans for mido: https://github.com/orgs/mido/discussions/540

Expect a new alpha once mido 2.0 alpha shows up ;)

Thanks for the kind words, good luck for your project and hope you'll stick around.