search

EMCECS / ecs-object-client-java

Java SDK for storing objects in ECS
Other
21 stars 14 forks source link

JakartaEE 10 support #110

Open JSamir opened 4 months ago

JSamir commented 4 months ago

We are migrating our application to JakartaEE 10 and faced issues, it seems the client does not support running in JakartaEE 10 context.

Is there a plan to make it JEE10 compatible?

dunedodo commented 2 months ago

Currently we have not planned targeting JakartaEE.

JSamir commented 2 months ago

Since we were migrating our own application and therefore are familiar with the topic, we tried patching the ecs client ourselves. In general it works for us, although someone with knowledge about the internals of the client would need to have a look at few minor issues.

Would you accept a PR?

dunedodo commented 2 months ago

Yes, please. We will help review.

JSamir commented 1 month ago

We're currently building a release thus I will only have time for the PR in 1-2 weeks.

But one thing I wanted to mention already is that the changes we have made would make things work with JEE10, but JEE8 would not work (anymore). So you would either need to drop JEE8 support or somehow make both work.

dunedodo commented 11 hours ago

We're currently building a release thus I will only have time for the PR in 1-2 weeks.

But one thing I wanted to mention already is that the changes we have made would make things work with JEE10, but JEE8 would not work (anymore). So you would either need to drop JEE8 support or somehow make both work.

Thank you. I don't quite know how compatability work in JakartaEE 10 with Java 8 and 11, but object-client should always support Java 8 and 11. It looks like JakartaEE 9 works with Java 8 and Java 11? FYI., we are likely to have Java 17 support in the future which is TBD, not sure if this can help. It doesn't work ATM though.