Some of the emf_heresy laws have invalid law modifiers

[zijistark]

E.g., global_tax_modifier is an invalid law modifier, and yet it's indeed in use by some emf_heresy laws. This is now extra obvious in-game because the tooltip separates out the invalid modifiers and says something to the effect of "MODIFIERS THAT WILL BE LOST:" (which is admittedly a very strange choice of description but nevertheless).

In order to address this & get the full intended effects of these heresy-related laws where they actually matter in any significant way, we need to go through and:

• [ ] Make a list of all the laws with invalid modifiers & which modifiers in use are invalid.
• [ ] For each such (law, invalid modifier), determine whether it really matters much at all. If not and this ends up being true for all of (law, *), then just delete the invalid modifiers for that law and call it good.
  • May also want to consider the law group as a whole for invalid modifier irrelevance, as in some situations, that may be necessary for coherence.
• [ ] For each of the rest of the affected laws, we need to create a corresponding character modifier that contains the modifiers which were invalid in the context of a law/title.
• [ ] When that law is passed (even by default / automatically — ergo directly part of the law's effect and not part of pass_effect), the corresponding character modifier shall be added to the character & any mutually exclusive character modifiers (from the same law group, presumably) are cleared.
  • Might require a startup event to assess all such laws' settings post-startup & validate the associated character modifiers on the title holder. Not required by any means, but it's generally a good practice to ensure that the game is in a fully coherent state when it starts (i.e., no need to wait for some arbitrary maintenance period to elapse if you see something incoherent in the game, you can just save & reload).
  • We need to reliably remove the character-law modifiers whenever that character no longer fulfills the potential of the law corresponding to a character modifier which they possess. @Ispil suggested just using hidden character modifiers since most or all of these modifiers don't matter for non-rulers, but there are theoretically other ways to have the law auto-removed from your primary title without losing any titles (e.g., if you no longer fit the potential of the law, save the game, quit, and load it up later). It also occurs on religion, government, and culture change AFAIK, but we really shouldn't try to rely on when law validation is done, as that is fragile & just overcomplicated.
• [ ] Write an on_yearly_pulse event to renew the appropriate character-law modifiers, setting their auto-expiry for 2 years later each time. This ensures that the modifier never prematurely expires before we hit another yearly pulse to [maybe] renew it, but it's a perfectly acceptable duration to just let the engine take care of auto-expiry of all such modifiers if a character (ruler or not) no longer meets the law criteria.

Using the modifier auto-expiry feature enables us to be fairly care-free about applying the modifiers (though exclusive modifiers still need to be cleared when a different law setting is passed) whilst still being able to effectively remove them from ALL types of characters (not just rulers) efficiently.

[zijistark]

Also:

• [ ] Hack up the <law>_desc tooltips to show the effects of the character-law modifiers directly in the law tooltip just like all the regular law modifiers as best as we can.

[zijistark]

Closing, as @DelnarErsike addressed this more or less.