search

EMFTeam / EMF

Extended Mechanics & Flavor
34 stars 18 forks source link

EMF's NDE (duel engine) is now deprecated, but it's still invoked from a few places. #589

Closed zijistark closed 5 years ago

zijistark commented 5 years ago

At least one of those places, off the top of my head, is from EMF's coronation celebrations (some rivals at the event decide to duel one another). I think another usage is when you and your regent get into a duel.

We need to figure out how to invoke the HFP (Holy Fury Patch, i.e., free content) duel system with all of the proper context required for a coherent duel, and then we need to replace all invocations of the NDE and drop NDE from the codebase.

zijistark commented 5 years ago

The only place where the NDE was still invoked was in the EMF coronation system. I reconnected the event chain for a coronation duel to the HFP/3.0 duel "challenged accepts duel" code with appropriate event targets, etc. I did NOT bother trying to route all the possible win/loss outcomes back to the coronation feast host (which is then announced to everybody attending), so that part of the chain is now dead weight. So be it.

In so doing, I was able to delete the NDE / "New" Duel Engine from the EMF codebase.