EMFTeam / EMF

Extended Mechanics & Flavor
34 stars 18 forks source link

Aganatic Elective Monarchy succession doesn't allow unlanded adult male siblings of the ruler to be nominated despite the description of the law claiming otherwise. #600

Closed zijistark closed 5 years ago

zijistark commented 5 years ago

This came up when trying to recreate the historical Wessex succession of Alfred the Great from Aethelred (his brother).

Details: Gender law: agnatic_succession Succession law: succ_feudal_elective

Either the voting rules need adjustment, or the description of the law will have to be changed.

zijistark commented 5 years ago

It seems the issue is still unsolved. However, I've done a quick overhaul of the succ_feudal_elective voting rules, and the incoming commit may fix it. [It also changes the behavior of valid electors for kingdom titles -- allowing counts and dukes instead of just dukes, it fixes a couple vanilla bugs, it allows indirect vassals in general to be electors, much like the more traditional implement of FE succession, and and it allows candidates to be counts or dukes instead of just dukes under a kingdom title as well.]

zijistark commented 5 years ago

My last commit on this unfortunately didn't permit Alfred of Wessex, full brother of the King of Wessex in 867, to be nominated as a successor. At this point, we simply have to give up: I ran a further test where the voting rules' candidate_trigger was just always = yes and the King's brother still wasn't included in the list of potential candidates, AFAICT. Ultimately, we only get the candidate pool that the hard-coded base succession type provides, and feudal_elective apparently does not actually allow close relatives of the ruler that aren't their progeny — or at least not the brothers of the ruler.

The description of the succession law (tooltip, I think) should be updated, because it contradicts this.

zijistark commented 5 years ago

Apparently this works in vanilla, according to Rhone on Discord. The only difference is that the kingdom is k_wessex and whatever other setup differences on SWMH. Harald Godwinson could nominate his brothers; the King of France, once set to elective, could nominate unlanded brothers.

In vanilla, after forcing Elective Monarchy on the Duchy of Wessex (they have no such kingdom), he got this (do note that his brother is landed, though): image

Fedual Elective kingdom vanilla. Both brothers landed and unlanded can be nominated as heir. image

Finally:

Fyi the paradox guy told me he tried to recreate bug as king of France in 1066 vanilla and COULD nominate brother.

zijistark commented 5 years ago

I tried to replicate 1066 Saxon England on E+V and failed to be able to nominate my unlanded brothers.

zijistark commented 5 years ago

I deleted EMF's overrides of both succession_voting files & tried on E+S. Alfred (the brother) was a candidate, although he was landed, so I decided to usurp all his titles & run the game for a day & ensure he was in my court/realm still. This worked:

image

Unfortunately, I also changed something in SWMH that was a hunch, so I don't know whether it's EMF's succession voting overrides or that yet.

zijistark commented 5 years ago

I undid the aforementioned change in SWMH & the brother remains a valid candidate when EMF's succession voting files are removed. Not sure where to begin with this one, other than I could start with vanilla and iteratively do it all over again, as I know that code pretty well. The only thing that might be affecting whether this brother-candidate is filtered out of the pool or not would be the gargantuan modifier set in candidate_vote_score somehow giving the brother a negative score, which would disqualify if I understand correctly.