EMFTeam / EMF

Extended Mechanics & Flavor
34 stars 18 forks source link

Nomad Agitation trigger is triggering on wrong provinces #633

Closed Ispil closed 5 years ago

Ispil commented 5 years ago

As related to a rare issue where Basel would become an independent nomad state, it would appear that the trigger for applying nomad agitation to a province merely specifies that it holds either no holding at all when conquered, or simply a temple. This, naturally, leads to situations where provinces with merely a bishopric (Basel being the usual example), once conquered, become a target for nomad agitation. There's also the reverse scenario, where a province that should trigger nomad agitation (several in Qazarstan in 867, where they are a single nomad holding coupled with a tribe) does not.

Additionally, when those provinces are released, characters are not properly generated- the released nomad is married to another man.

To reproduce this issue, start in any start date with the HRE ruling over Basel. Choose the Emperor of the HRE to start. Run emf_debug.0, and force-usurp Basel. Grant it to anyone, then die. Upon doing so, Basel will become an independent nomad clan.

Relevant events are HL.4999 (the event that applies that nomad agitation modifier), and HL.4998 (the event that actually releases the province), found in hl_nomad_events.txt

In short, the trigger for nomad agitation must be more robust than a simple holding check.

zijistark commented 5 years ago

A screenshot of it happening in Bihar: image

zijistark commented 5 years ago

A screenshot of it having already happened in Basel: image

zijistark commented 5 years ago

A screenshot of another time w/ the homosexual marriage bit: image

zijistark commented 5 years ago

Closing for now. If we see this strange behavior again, please reopen issue.