codecov[bot]
commented
8 months ago Codecov Report
Attention: Patch coverage is 64.28571% with 15 lines in your changes are missing coverage. Please review.
Project coverage is 84.03%. Comparing base (
606738b) to head (793e101).
| Files | Patch % | Lines |
|---|---|---|
| app/main.py | 46.15% | 14 Missing :warning: |
| app/redis_cache/_redis.py | 93.75% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #413 +/- ## ========================================== + Coverage 78.59% 84.03% +5.44% ========================================== Files 23 23 Lines 696 708 +12 ========================================== + Hits 547 595 +48 + Misses 149 113 -36 ``` | [Flag](https://app.codecov.io/gh/EMMC-ASBL/oteapi-services/pull/413/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EMMC-ASBL) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/EMMC-ASBL/oteapi-services/pull/413/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EMMC-ASBL) | `84.03% <64.28%> (+5.44%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EMMC-ASBL#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description:
Closes #412
Update event handling in app to use
lifespan.Still to do:
--live-rediswith an associated fixturelive_rediswhich signifies the user expects the tests to use a live Redis instance.Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.