EMODnet / emodnet.wfs

Access EMODnet Web Feature Service data through R
https://emodnet.github.io/emodnet.wfs/
Other
8 stars 4 forks source link

refactor: remove tryCatch() that hides the error message #161

Closed maelle closed 7 months ago

maelle commented 8 months ago

I noticed that the tryCatch() did not work because the error condition does not have access to service_url. Furthermore, what was needed for me was the actual error. So I propose removing check_service() and instead document the existence of the monitor.

Note the builds won't pass until #159 or another fix is merged.

salvafern commented 7 months ago

Hi @maelle , I believe we will be loosing some nice error messages as well (e.g. no internet). But surfacing other error messages is also a good idea. I agree but maybe would be good a quick review by @annakrystalli ?

maelle commented 7 months ago

I can see that but at the same time, if one doesn't have an internet connection, it's easy to notice even without R? :thinking:

salvafern commented 7 months ago

fair enough :)