EMS-TU-Ilmenau / fastmat

A library to build up lazily evaluated expressions of linear transforms for efficient scientific computing.
https://fastmat.readthedocs.io
Apache License 2.0
24 stars 8 forks source link

Bug in Fourier: wrong complexity estimates #37

Closed ChristophWWagner closed 5 years ago

ChristophWWagner commented 5 years ago

When Fourier optimization decides to apply Bluestein's method the class instance incorrectly reports the complexity estimate for the (apparently worse conditioned) baseline fourier order. For larger sizes this can lead to the undesired effect, that a dense matrix multiplication is enforced (which should not be neccessary). Also, there is a mismatch in complexity estimate and actual computation, which is reflected in bad calibration estimates.

Suggested fix: Add a complexity estimation for the actual FFT complexity.

SebastianSemper commented 5 years ago

Resolved with #39 – closing.