search

EMS-TU-Ilmenau / fastmat

A library to build up lazily evaluated expressions of linear transforms for efficient scientific computing.
https://fastmat.readthedocs.io
Apache License 2.0
24 stars 8 forks source link

Bugfix #48

Closed ChristophWWagner closed 5 years ago

ChristophWWagner commented 5 years ago

Some bug fixes and extensions. Resolves issues #37, #39, #40, #41, #42, #44

Previous pull request was withdrawn.

SebastianSemper commented 5 years ago

So commit 124cf96 "cleans up code clarity"? Does this introduce some much needed chaos? :3

ChristophWWagner commented 5 years ago

Yeah. It's true. Totally clear to me. So sad.

ChristophWWagner commented 5 years ago

I shouldn't have cherry-picked the docu stuff from the int16 branch where it was pushed accidentially. Could have been easier just to accept it there, when this branch was still working ¯_(ツ)_/¯

SebastianSemper commented 5 years ago

Well now that shit has hit the fan, how do we proceed? :3

On Fri, 9 Nov 2018 at 10:05, Christoph Wagner notifications@github.com wrote:

I shouldn't have cherry-picked the docu stuff from the int16 branch where it was pushed accidentially. Could have been easier just to accept it there, when this branch was still working ¯(ツ)/¯

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/EMS-TU-Ilmenau/fastmat/pull/48#issuecomment-437295572, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDZRuftyHfSqSmyLd3kq9ScwJdYlTLiks5utUVmgaJpZM4YTBBg .

ChristophWWagner commented 5 years ago

I do what I should hae done in the first place: Merge in int16 and do both pull requests in one. Currently having IT problems. Hopefully the VM starts after lunch or there is some shit that will hit the fan at hp support ;)

SebastianSemper commented 5 years ago

Alright. Let's see how this plays out. :) Good luck with the HP!

On Fri, 9 Nov 2018 at 11:22, Christoph Wagner notifications@github.com wrote:

I do what I should hae done directly. Merge in int16 and do both pull requests at one. Currently having IT problems. Hopefully the VM starts after lunch or there is some shit that will hit the fan at hp support ;)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/EMS-TU-Ilmenau/fastmat/pull/48#issuecomment-437315957, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDZRgfSIJekMhTmME2t8Xc_EmxBjlsdks5utVdogaJpZM4YTBBg .

ChristophWWagner commented 5 years ago

Thanks, should be fine now. Happy approving! :)