search

EMS-TU-Ilmenau / fastmat

A library to build up lazily evaluated expressions of linear transforms for efficient scientific computing.
https://fastmat.readthedocs.io
Apache License 2.0
24 stars 8 forks source link

STELA can't handle complex valued inputs #76

Closed JanKirchhofTU closed 4 years ago

JanKirchhofTU commented 5 years ago

STELA seems to have problems handling complex values. For example, running the cs_example in the example section of the documentation (cf. commit d513a8d2bfa381cb69acff328eab1bd92d7e7104) leads to the following warning:

/STELA.py:238: ComplexWarning: Casting complex values to real discards the imaginary part                                                                                                                                  
  0

and the reconstruction is then useless.

JanKirchhofTU commented 4 years ago

Is this solved with b22d18fc385db32d85ba1b24f09991f8d06d110a? @SebastianSemper?

SebastianSemper commented 4 years ago

Don't think so.

JanKirchhofTU notifications@github.com schrieb am Fr., 24. Apr. 2020, 17:11:

Is this solved with b22d18f https://github.com/EMS-TU-Ilmenau/fastmat/commit/b22d18fc385db32d85ba1b24f09991f8d06d110a? @SebastianSemper https://github.com/SebastianSemper?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EMS-TU-Ilmenau/fastmat/issues/76#issuecomment-619070723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINSRRHMPN5JYJNKMLQGK3ROGT2RANCNFSM4IKUTAAQ .

JanKirchhofTU commented 4 years ago

The added conj() in Line 219 indicates the opposite and a quick test gave correct results with complex valued inputs. Closing.