Closed LalithShiyam closed 2 years ago
I addressed the most changes and updated the branch for #18.
Implemented changes regarding the review
Changes ToDo:
The changes ran without any errors or unexpected behaviour in a simple test case. Same outcome as before changes with the expected result of the determined starting frame. mpire implementation needs a bit more testing before I will add it.
Hi @Keyn34, cool! I went through the changes, and I think the function find_start_frame
in preProcessing.py
doesn't return anything now. I might be wrong...
For the time being we can stall mpire
parallel processing. And add it later as well. Whatever is convenient.
@LalithShiyam, it does return the index of the corresponding starting frame. Or what do you mean? Did I miss something?
I'll add it soon - just need a bit more time for testing and maybe rearranging the functions and how they work/enclosed they are.
@Keyn34: LOL, yes sorry my bad! I missed it 🍋
30 Basically address the comments present here!