ENHANCE-PET / FALCON

FALCON is a Python-based software application designed to facilitate PET motion correction, both for head and total-body scans. Our program is built around the fast 'greedy' registration toolkit, which serves as the registration engine. With FALCON, users can enjoy a streamlined experience for implementing motion correction.
GNU General Public License v3.0
36 stars 6 forks source link

Aesthetics: Cleaned up preprocessing.py #31

Closed LalithShiyam closed 2 years ago

LalithShiyam commented 2 years ago

30 Basically address the comments present here!

Keyn34 commented 2 years ago

I addressed the most changes and updated the branch for #18.

Implemented changes regarding the review

Changes ToDo:

The changes ran without any errors or unexpected behaviour in a simple test case. Same outcome as before changes with the expected result of the determined starting frame. mpire implementation needs a bit more testing before I will add it.

LalithShiyam commented 2 years ago

Hi @Keyn34, cool! I went through the changes, and I think the function find_start_frame in preProcessing.py doesn't return anything now. I might be wrong...

For the time being we can stall mpire parallel processing. And add it later as well. Whatever is convenient.

Keyn34 commented 2 years ago

@LalithShiyam, it does return the index of the corresponding starting frame. Or what do you mean? Did I miss something?

I'll add it soon - just need a bit more time for testing and maybe rearranging the functions and how they work/enclosed they are.

LalithShiyam commented 2 years ago

@Keyn34: LOL, yes sorry my bad! I missed it 🍋