search

ENSL / ensl.org

The ENSL website. http://ensl.org
MIT License
5 stars 9 forks source link

Errors with shout messages #12

Closed cblanc closed 9 years ago

cblanc commented 9 years ago

I've been able to identify a number of issues with shout messages:

1) When a shout message fails to create, i.e. a ban or invalid message, the action will fail silently as the client side code used to retrieve comments does not handle failure scenarios. Possible solution: update client side JS to handle non-200

2) It's not apparent when shout messages will fail prior to shout message creation. Possible solution: update client side JS which highlights invalid shouts + reason

3) Shout message controller set to respond_to :html, :js for all methods however not all methods are capable of rendering a response for both. Possible solution: finish implementing the incomplete methods so everything is capable of rendering a js and non-js response

Issue prompted by following comments earlier:

wob [3:45 PM] 
Did someone delete my shoutbox comment about it? .__.
vindaloo [3:58 PM] 
Sometimes I write comment and it shows, but as soon as I reload the page it's gone. Maybe some spam protection, it's mostly long comments that don't go trough. Sometimes I can see message on top of the page when i reload, error writing/submitting message, or something. But didn't make time to troubleshoot the issue. Or maybe someone is consistently trolling me for past year or so, not ruling anything out :simple_smile:
cblanc commented 9 years ago

No.1 + No.2 done as of 34f1fec127a3a8f5bb4520760f96ef595dc3ea7d