ENZYME-APD / tapir-archicad-automation

The easiest way to use the JSON/Python API from Archicad without knowing how to code.
MIT License
57 stars 17 forks source link

HighlightElementsComponent #194

Closed tlorantfy closed 4 days ago

tlorantfy commented 1 week ago

https://github.com/user-attachments/assets/d033b58f-da7f-4005-a488-1c64deb1a291

JBENEITEZ commented 4 days ago

Tested and working very well! A minor suggestion for the next release, @tlorantfy, maybe you could set the necessary toggles and colour swatches by default like you did with the value list in the "select by type" node? This will make a lot faster the workflow avoiding the user to add the necessary inputs.

JBENEITEZ commented 4 days ago
Screenshot 2024-11-03 at 9 23 04 PM
JBENEITEZ commented 4 days ago

All set up false by default

kovacsv commented 4 days ago
Screenshot 2024-11-03 at 9 23 04 PM

Transparency is not a boolean, but a number between 0.0 and 1.0.

kovacsv commented 4 days ago

@JBENEITEZ i think setting up default values is a better way than placing a lot of additional nodes. I think the script can easily become bloated by nodes when a default value would work perfectly fine.

JBENEITEZ commented 4 days ago

@kovacsv is fair enough, but the default behaviour from the user will be to go and find the toggles and swatches in order to activate it and make it work. My proposal is merely to add the inputs that are necessary to make it work, perhaps as you say, with some default values you can save a few extra nodes here and there.

kovacsv commented 4 days ago

@JBENEITEZ i agree, but if the default is good enough for temporary highlight then users won't need to add anything, only the element id input. For more complex worklows a swatch won't be enough.

Let's say this is a default:

I think this would cover the workflow when you just want to see what is selected. If you want to customize it you should create nodes only for the things you want to change.

JBENEITEZ commented 4 days ago

I am convinced! That seems very reasonable