GetPropertyValuesOfElementsComponent

[tlorantfy]

[tlorantfy]

@kovacsv , Grasshopper freezes when I try to connect AllProperties with GetPropertyValues, see below video. It takes around 1 minute to evaluate :D

https://github.com/user-attachments/assets/12fd9590-7b56-4e05-8e3f-8278ab97930f

[kovacsv]

@kovacsv , Grasshopper freezes when I try to connect AllProperties with GetPropertyValues, see below video. It takes around 1 minute to evaluate :D

GetPropertyValues.mp4

Based on the code it shouldn't work at all. PropertyId is a list, and that input accepts an item only.

[tlorantfy]

Based on the code it shouldn't work at all. PropertyId is a list, and that input accepts an item only.

Why shouldn't work? Grasshopper works like this: if the input accepts an item but it gets a list then SolveInstance function of the component will be executed N times, for each item in the list. So it works correctly now, but slow for huge number of properties.

I implemented this because the existing SetPropertyValues component accepts a propertyId item also.

But probably it's better to change the input to accept list of propertyIds for GetPropertyValues node. That way the Tapir command will be executed only once when getting values for N properties of M elements. For SetPropertyValues it makes the inputs more complicated...

[kovacsv]

Based on the code it shouldn't work at all. PropertyId is a list, and that input accepts an item only.

Why shouldn't work?

Grasshopper works like this: if the input accepts an item but it gets a list then SolveInstance function of the component will be executed N times, for each item in the list.

So it works correctly now, but slow for huge number of properties.

I implemented this because the existing SetPropertyValues component accepts a propertyId item also.

But probably it's better to change the input to accept list of propertyIds for GetPropertyValues node. That way the Tapir command will be executed only once when getting values for N properties of M elements.

For SetPropertyValues it makes the inputs more complicated...

Thanks for the clarification. I thought item input can't accept lists, but it seems like it can. Then it's not a big surprise that it's slow, it runs 1600 separate calls to Archicad.

[tlorantfy]

Updated, now it executes the GetPropertyValuesOfElements Tapir command only once, even if getting values for multiple properties. It's much more faster now.

Notes:

• If the input is only 1 propertyId, that's OK, Grasshopper automatically converts that to a list, so the component can accept it.
• If the input is the list of propertyIds, so getting values for multiple properties, then both ElementIds and Values outputs are trees, but I think 2D-List is a better word for that. So ElementIds[N][M] is the Mth element the Nth property is available for, and Values[N][M] is the Nth property value of ElementIds[N][M]. It's pretty clear, right? :D