search

EOEPCA / deployment-guide

EOEPCA Deployment Guide
https://deployment-guide.docs.eoepca.org/
Apache License 2.0
3 stars 7 forks source link

Rework Ingress Controller to include APISIX #24

Closed rconway closed 6 days ago

rconway commented 1 week ago

Major rework to introduce the alternative APISIX ingress controller that is advocated by the IAM solution.

james-hinton commented 1 week ago

Great! Theres quite a lot of yaml code in this, do you think that we should move into it it's own dedicated directory inside of /scripts, or do you think it's clearer having it here i.e. not requiring a git clone?

rconway commented 1 week ago

Not sure. I followed the approach of the existing ingress controller page that was not relying upon scripts. The yaml is wrapped in bash - so you can just copy/paste into terminal and hit return. Also, since this is ingress - sort of outside the scope of our BBs - then maybe just sharing the yaml is OK.

Also, because the page presents choices, we might over-complicate if we started to script things. The idea of this page is to educate the user, describe the options and let the user decide how to proceed - possibly adapting what is presented in the page - treating the information as a starting point.

james-hinton commented 1 week ago

Good points!

spinto commented 1 week ago

please do not forget to make clear for what this APISIX controller is needed/recommended in the pre-requisites for the K8S cluster