Closed EOGrady21 closed 2 years ago
I think I will settle on A-
The remaining issues could be looked at but might be more involved to fix. Some restructuring to avoid sink()
would be best practice...
A lot of the remaining 'issues' are TODO comments, which I personally like for keeping track of development opportunities.
I plugged the
vprr
code into CodeFactor which runs through some automated checks and returns a 'grade' on your R code. https://www.codefactor.io/repository/github/eogrady21/vprr/issues/main We are currently getting a B.I think a lot of these issues are repetitive and easy to fix. The largest chunk of issues are the suggestion of using
seq_len()
to run loops instead of1:length(x)
.It would be nice to tidy these up as part of our renewed tidy effort in
vprr
. Plus bragging rights that come with an A+ would be nice!